On Fri, 2007-11-16 at 15:19 +0100, pHilipp Zabel wrote:

quoted

quoted

On Nov 16, 2007 6:33 AM, Herbert Valerio Riedel [off-list ref] wrote:

quoted

Currently, gpio_keys.c assumes the GPIOs to be already properly configured;
this patch changes gpio-keys to perform explicit calls to gpio_request() and
gpio_configure_input().

This matches the behaviour of leds-gpio.

quoted

quoted

Makes sense from where I sit but let's see what guys who actually use
the module say... ;)

[..]

We have quite a big number of users in the handhelds.org CVS kernel tree.

Unfortunately we are traditionally slow at pushing things to mainline, and many
of the devices depend on something like gpiolib hitting mainline for their GPIO
extenders.

well, is there any chance this patch of mine might make it for 2.6.25?
(or maybe even 2.6.24, since it can be regarded as being an actual
fix...?) :-)

regards,
hvr