On Nov 16, 2007 3:09 PM, Herbert Valerio Riedel [off-list ref] wrote:

On Fri, 2007-11-16 at 08:38 -0500, Dmitry Torokhov wrote:

quoted

On Nov 16, 2007 6:33 AM, Herbert Valerio Riedel [off-list ref] wrote:

quoted

Currently, gpio_keys.c assumes the GPIOs to be already properly configured;
this patch changes gpio-keys to perform explicit calls to gpio_request() and
gpio_configure_input().

This matches the behaviour of leds-gpio.

quoted

Makes sense from where I sit but let's see what guys who actually use
the module say... ;)

I grepped through my 2.6.24-git source tre, and the only places I found
gpio_keys.h included was

drivers/input/keyboard/gpio_keys.c:#include <linux/gpio_keys.h>
arch/arm/mach-orion/dns323-setup.c:#include <linux/gpio_keys.h>
arch/arm/mach-at91/board-sam9261ek.c:#include <linux/gpio_keys.h>

with dn323-setup.c being maintained by myself, and board-sam9261ek.c
having seemingly non-compilable code wrt to gpio_keys (for instance, it
uses ".keycode" gpio_keys_button  struct members which should have been
".code"), there don't seem to exist many users of that module...? :-)

We have quite a big number of users in the handhelds.org CVS kernel tree.
Unfortunately we are traditionally slow at pushing things to mainline, and many
of the devices depend on something like gpiolib hitting mainline for their GPIO
extenders.

regards
Philipp