Re: [PATCH v3] ata: ahci_da850: switch to DEFINE_SIMPLE_DEV_PM_OPS

On 9/8/26 17:45, Niklas Cassel wrote:

On Tue, Sep 08, 2026 at 03:13:49PM +0900, Damien Le Moal wrote:

quoted

On 9/8/26 15:10, Li Jun wrote:

quoted

Replace the deprecated SIMPLE_DEV_PM_OPS macro with the recommended
DEFINE_SIMPLE_DEV_PM_OPS. Use pm_ptr(&ahci_da850_pm_ops) to complete
the API migration and allow the structure to be correctly dropped
when CONFIG_PM=n.

Signed-off-by: Li Jun <redacted>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
---
changelogs:
-add pm_ptr for ahci_da850_pm_ops in ahci_da850_driver.
-revise grammar and alignment issues.
---
 drivers/ata/ahci_da850.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
index 4e53ff96d712..469cf015bbf0 100644
--- a/drivers/ata/ahci_da850.c
+++ b/drivers/ata/ahci_da850.c

@@ -218,8 +218,8 @@ static int ahci_da850_probe(struct platform_device *pdev)
 	return rc;
 }
 
-static SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend,
-			 ahci_platform_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend,
+								ahci_platform_resume);

You resent the same v3... Did you mean to send a fixed v4? Or is it me for some
reason getting the same patch email twice?

I just received a single v2 and a single v3.

Indeed, I missed v3 in the email subject.

The commit log is different from v2 and v3, and your Review-tag was picked
up. However, the indentation still looks wrong. It seems to have 8 tabs
instead of 4.

And yes, the indentation is still wrong.
Maybe fix it when applying?

Kind regards,
Niklas

-- 
Damien Le Moal
Western Digital Research