Re: [PATCH v3] ata: ahci_da850: switch to DEFINE_SIMPLE_DEV_PM_OPS
From: Damien Le Moal <dlemoal@kernel.org>
Date: 2026-09-08 06:14:01
On 9/8/26 15:10, Li Jun wrote:
quoted hunk ↗ jump to hunk
Replace the deprecated SIMPLE_DEV_PM_OPS macro with the recommended DEFINE_SIMPLE_DEV_PM_OPS. Use pm_ptr(&ahci_da850_pm_ops) to complete the API migration and allow the structure to be correctly dropped when CONFIG_PM=n. Signed-off-by: Li Jun <redacted> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> --- changelogs: -add pm_ptr for ahci_da850_pm_ops in ahci_da850_driver. -revise grammar and alignment issues. --- drivers/ata/ahci_da850.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c index 4e53ff96d712..469cf015bbf0 100644 --- a/drivers/ata/ahci_da850.c +++ b/drivers/ata/ahci_da850.c@@ -218,8 +218,8 @@ static int ahci_da850_probe(struct platform_device *pdev) return rc; } -static SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend, - ahci_platform_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend, + ahci_platform_resume);
You resent the same v3... Did you mean to send a fixed v4? Or is it me for some reason getting the same patch email twice?
quoted hunk ↗ jump to hunk
static const struct of_device_id ahci_da850_of_match[] = { { .compatible = "ti,da850-ahci", },@@ -233,7 +233,7 @@ static struct platform_driver ahci_da850_driver = { .driver = { .name = DRV_NAME, .of_match_table = ahci_da850_of_match, - .pm = &ahci_da850_pm_ops, + .pm = pm_ptr(&ahci_da850_pm_ops), }, }; module_platform_driver(ahci_da850_driver);
-- Damien Le Moal Western Digital Research