Hi Alex,

Thanks for testing!

On 17/06/21 9:11 am, ALeX Kazik wrote:

Hi,

I've tested the patches and they work.

At first I got it only to work with the following line removed/commented out:
   if (apne_100_mbit)
And thus enabling the following line always.

I've changed, with the help of Michael, the parameters to:

   static u32 apne_100_mbit = 0;
   module_param_named(100_mbit, apne_100_mbit, uint, 0644);
   MODULE_PARM_DESC(100_mbit, "Enable 100 Mbit support");

And was able to enable it with the kernel option "apne.100_mbit=1".

It's also available as /sys/module/apne/parameters/100_mbit

The 0644 is the permission (root can change it), If it shouldn't be
changed at runtime 0444 or 0 would be used.

Changing that parameter at runtime won't do anything (it's only tested 
at device probe time). But I'd better change the permission to 444.

(I think there is also a bool option instead of the uint, but I'm glad
it works like this.)

True, that would be the better option indeed. I'll change that in the 
next version (which will go to netdev as well).

Cheers,

     Michael

Alex.