Thread (64 messages) 64 messages, 6 authors, 2021-06-17

Re: [PATCH v2] m68k: io_mm.h: conditionalize ISA address translation on Atari

From: Michael Schmitz <schmitzmic@gmail.com>
Date: 2021-06-09 21:45:07
Also in: linux-m68k

Hi Andreas,

On 9/06/21 7:57 pm, Andreas Schwab wrote:
On Jun 09 2021, Michael Schmitz wrote:
quoted
@@ -135,10 +139,13 @@ static inline u8 __iomem *isa_itb(unsigned long addr)
      case ISA_TYPE_AG: return (u8 __iomem *)AG_ISA_IO_B(addr);
  #endif
  #ifdef CONFIG_ATARI_ROM_ISA
-    case ISA_TYPE_ENEC: return (u8 __iomem *)ENEC_ISA_IO_B(addr);
+    case ISA_TYPE_ENEC:
+	if (addr < 1024)
+		return (u8 __iomem *)ENEC_ISA_IO_B(addr);
+	break; /* not ROM port? fallback below! */
  #endif
-    default: return NULL; /* avoid warnings, just in case */
      }
+    return (u8 __iomem *)(addr); /* avoid warnings, just in case */
I don't think the comment still fits here.
True - I'll remove it.

Cheers,

     Michael

Andreas.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help