Thread (27 messages) 27 messages, 1 author, 2020-02-07
STALE2356d

[PATCH v2 12/26] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2020-02-07 14:29:09
Also in: linux-m68k, lkml
Subsystem: libata subsystem (serial and parallel ata drivers), the rest · Maintainers: Damien Le Moal, Niklas Cassel, Linus Torvalds

When CONFIG_SATA_HOST=n there are no NCQ capable host drivers
built so it is safe to hardwire ata_ncq_enabled() to always
return zero.

Code size savings on m68k arch using (modified) atari_defconfig:

   text    data     bss     dec     hex filename
before:
  37820     572      40   38432    9620 drivers/ata/libata-core.o
  21040     105    4096   25241    6299 drivers/ata/libata-scsi.o
  17405      18       0   17423    440f drivers/ata/libata-eh.o
after:
  37582     572      40   38194    9532 drivers/ata/libata-core.o
  20702     105    4096   24903    6147 drivers/ata/libata-scsi.o
  17353      18       0   17371    43db drivers/ata/libata-eh.o

Signed-off-by: Bartlomiej Zolnierkiewicz <redacted>
---
 include/linux/libata.h | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 0f208df6428e..e461664ee0b9 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1631,6 +1631,8 @@ extern struct ata_device *ata_dev_next(struct ata_device *dev,
  */
 static inline int ata_ncq_enabled(struct ata_device *dev)
 {
+	if (!IS_ENABLED(CONFIG_SATA_HOST))
+		return 0;
 	return (dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF |
 			      ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ;
 }
-- 
2.24.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help