[PATCH v2 13/26] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts
From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2020-02-07 14:29:01
Also in:
linux-m68k, lkml
Subsystem:
libata subsystem (serial and parallel ata drivers), the rest · Maintainers:
Damien Le Moal, Niklas Cassel, Linus Torvalds
Add !IS_ENABLED(CONFIG_SATA_HOST) to ata_dev_config_ncq() to allow compiler to optimize out the function for non-SATA configs. Code size savings on m68k arch using (modified) atari_defconfig: text data bss dec hex filename before: 37582 572 40 38194 9532 drivers/ata/libata-core.o after: 36462 572 40 37074 90d2 drivers/ata/libata-core.o Signed-off-by: Bartlomiej Zolnierkiewicz <redacted> --- drivers/ata/libata-core.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 408dee580f24..73727a7f295b 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c@@ -2287,6 +2287,8 @@ static int ata_dev_config_ncq(struct ata_device *dev, desc[0] = '\0'; return 0; } + if (!IS_ENABLED(CONFIG_SATA_HOST)) + return 0; if (dev->horkage & ATA_HORKAGE_NONCQ) { snprintf(desc, desc_sz, "NCQ (not used)"); return 0;
--
2.24.1