Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page
From: Tejun Heo <tj@kernel.org>
Date: 2016-07-21 21:26:37
Also in:
linux-next, linux-scsi, lkml
On Fri, Jul 22, 2016 at 02:41:54AM +0800, tom.ty89@gmail.com wrote:
quoted hunk ↗ jump to hunk
@@ -3854,6 +3852,8 @@ static unsigned int ata_scsi_mode_select_xlat(struct ata_queued_cmd *qc) if (ata_mselect_control(qc, p, pg_len, &fp) < 0) { fp += hdr_len + bd_len; goto invalid_param; + } else { + goto skip; /* No ATA command to send */
Hmmm... I'm a bit confused. Why is mselect_control path different from mselect_caching in terms of qc handling? Thanks. -- tejun