Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()
From: Tom Yan <hidden>
Date: 2016-07-21 18:51:06
Also in:
linux-next, linux-scsi, lkml
This patch should cause no behavioral change. Even the (removal of) the redundant bit mask should be a nop. So it seems like a bit of an overkill to split them. On 22 July 2016 at 02:45, Sergei Shtylyov [off-list ref] wrote:
Hello. On 07/21/2016 09:41 PM, tom.ty89@gmail.com wrote:quoted
From: Tom Yan <redacted> 1. Removed a repeated bit masking in ata_mselect_control() 2. Moved `wce`/`d_sense` assignment below the page validity checks 3. Added/Removed empty lines where appropriate Signed-off-by: Tom Yan <redacted>Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch is a better practice. [...] MBR, Sergei