On Tuesday 25 September 2012 16:01:35 Aaron Lu wrote:

On Mon, Sep 24, 2012 at 11:40:18PM +0200, Rafael J. Wysocki wrote:

quoted

On Monday, September 24, 2012, Aaron Lu wrote:

quoted

On Mon, Sep 24, 2012 at 02:55:31PM +0200, Rafael J. Wysocki wrote:

I just checked the spec again and tested, when the ODD has power, it
will also send out notifications on pressing the eject button/inserting
a disc. So we should be able to capture such a event.

In this case there's no need to poll for disk change unless the button has
been pressed.

I'm thinking of enabling this GPE in sr_suspend once we decided that it
is ready to be powered off, so the time frame between sr_suspend and
when the power is actually removed in libata should be taken care of by
the GPE. If GPE fires, the notification function will request a runtime
resume of the device. Does this sound OK?

This sounds terribly, needlessly complicated. Just enable it when
you detect the presence of a disk drive that supports it.

Furthermore we have a device which can detect that a button has
been pressed. It is fundamentally wrong to poll for medium change in
such devices. You know that it hasn't been changed.
We should notify the upper layers that we can do medium change
detection on our own.

	Regards
		Oliver