On Tue, 2007-07-31 at 15:27 +0900, Tejun Heo wrote:

Jeff Garzik wrote:

quoted

Any chance the SCSI peeps could ACK this, and then let me include it in
the ALPM patchset in the libata tree?

ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM.  I'm not
sure whether this three level knob would be sufficient. 

adding more levels later is easy.

 It might be
good enough if we're gonna develop extensive in-kernel black/white list
specifying which method works on which combination but my gut tells me
that it's best left to userland (probably in the form of per-notebook PS
profile).

either sucks. AHCI ALPM ought to work if it's supported; it's what other
operating systems also use... 

Adding to the fun, there are quite a few broken devices out there which
act weirdly when link PS actions are taken.

do you have any specific examples that act funny with the patch in
question here? (the patch tries to be careful, previous patches weren't
always so please test this patch before claiming the concept as a whole
is broken)

Also, I generally don't think AHCI ALPM is a good idea.  It doesn't have
'cool down' period before entering PS state

that's a chipset implementation decision.... not part of the
spec/technology per se.