Re: LibPATA code issues / 2.6.15.4
From: Jesper Juhl <hidden>
Date: 2006-02-25 16:11:49
Also in:
lkml
On 2/25/06, Justin Piszcz [off-list ref] wrote: Please don't top-post.
The kernel is patched, if you did not get what you wanted maybe the patch does not work in some instances or there is a bug?
You may have patched a kernel source with Mark's patch, but you are
very clearly not running a kernel build from that patched source.
As can be seen from (for example) this bit from Mark's patch
translate_done:
- printk(KERN_ERR "ata%u: translated ATA stat/err 0x%02x/%02x to "
- "SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n", id, drv_stat, drv_err,
+ printk(KERN_ERR "ata%u: translated op=0x%02x ATA stat/err
0x%02x/%02x to "
+ "SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n", id, opcode,
drv_stat, drv_err,
*sk, *asc, *ascq);
the patch changes the text being printed. In this case the text
"ata%u: translated ATA stat/err ..." is changed into "ata%u:
translated ATA stat/err ..."
And if we look at the output you posted :
quoted
quoted
Here it is: [263864.109854] ata3: translated ATA stat/err 0x51/04 to SCSI SK/ASC/ASCQ 0xb/00/00
That string is clearly from an un-patched kernel as Mark also pointed out in his reply to you. -- Jesper Juhl [off-list ref] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html