Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
From: Jim Ramsay <hidden>
Date: 2005-08-24 16:12:35
Also in:
linux-scsi, lkml
From: Jim Ramsay <hidden>
Date: 2005-08-24 16:12:35
Also in:
linux-scsi, lkml
On 8/24/05, Jim Ramsay [off-list ref] wrote:
On 8/24/05, Lukasz Kosewski [off-list ref] wrote:quoted
On 8/24/05, Stefan Richter [off-list ref] wrote:quoted
quoted
quoted
Timers appear to operate in an atomic context, so timers should not be allowed to call scsi_remove_device, which eventually schedules. Any suggestions on the best way to fix this?Workqueue, perhaps.Perhaps. Actually, of course :)How about the existing ata_wq workqueue? This makes sense. When the timer expires, it adds a task to this queue.
Note to self - No, you cannot use the exsting 'ata_wq' workqueue - The plug-in events need to put other work on the queue during the hotplug event... and of course this deadlocks since you're in the queuethread already. -- Jim Ramsay "Me fail English? That's unpossible!"