Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2
From: Jim Ramsay <hidden>
Date: 2005-08-23 19:41:13
Also in:
linux-scsi, lkml
From: Jim Ramsay <hidden>
Date: 2005-08-23 19:41:13
Also in:
linux-scsi, lkml
On 8/1/05, Lukasz Kosewski [off-list ref] wrote:
Patch 03: Have sata_promise use the perfect, flawless API from the previous patch
Hmmm... Flawless :) Then I must have found an undocumented feature! I've applied this set of patches to a 2.6.11 kernel (with few problems) and ran into a bunch of "scheduling while atomic" errors when hotplugging a drive, culprit being probably scsi_sysfs.c where scsi_remove_device locks a mutex, or perhaps when it then calls class_device_unregister, which does a 'down_write'. Perhaps we need some sort of workqueue for hotplug requests to get them out of the atomic interrupt handler context where they originate? -- Jim Ramsay "Me fail English? That's unpossible!"