Thread (9 messages) 9 messages, 4 authors, 2005-02-10

Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access

From: Tejun Heo <hidden>
Date: 2005-02-10 00:53:20
Also in: lkml

  Okay, another quick question.

  To fix the io_32bit race problem in ide_taskfile_ioctl() (and later 
ide_cmd_ioctl() too), it seems simplest to mark the taskfile with 
something like ATA_TFLAG_IO_16BIT flag and use the flag in task_in_intr().

  However, ATA_TFLAG_* are used by libata, and I think that, although 
sharing hardware constants is good if the hardware is similar, sharing 
driver-specific flags isn't such a good idea.  So, what do you think?

  1. Add ATA_TFLAG_IO_16BIT to ata.h
  2. Make ide's own set of task flags, maybe IDE_TFLAG_* (including
     IDE_TFLAG_LBA48)

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help