Re: [PATCH libata-dev-2.6] Issue INITIALIZE DEVICE PARAMETERS for CHS only devices
From: Jeff Garzik <hidden>
Date: 2005-02-24 06:48:16
Albert Lee wrote:
Thanks for the detailed instruction. Attached please find the revised patch for your review.
Thanks for the updated patch. Patch looks OK except:
quoted hunk ↗ jump to hunk
--- libata-dev-2.6/drivers/scsi/libata-scsi.c 2005-02-2117:23:03.000000000 +0800+++ libata-dev-2.6-mod/drivers/scsi/libata-scsi.c 2005-02-2218:32:19.000000000 +0800@@ -785,6 +785,7 @@ if ((cyl >> 16) || (head >> 4) || (sect >> 8) || (!sect)) return 1; + tf->command = ATA_CMD_VERIFY; tf->nsect = n_block & 0xff; /* Sector count 0 means 256 sectors */ tf->lbal = sect; tf->lbam = cyl;@@ -875,7 +876,7 @@ /* Check and compose ATA command */ if (!n_block) - /* In ATA, sector count 0 are 256 or 65536 sectors, not 0sectors. */ + /* In ATA, sector count 0 means 256 or 65536 sectors, not 0 sectors. */
Please submit these libata-scsi changes in a separate patch. Jeff