Thread (28 messages) 28 messages, 5 authors, 2005-02-25

Re: [PATCH libata-dev-2.6] Issue INITIALIZE DEVICE PARAMETERS for CHS only devices

From: Mark Lord <hidden>
Date: 2005-02-23 14:49:44

 >This is the patch to issue INITIALIZE DEVICE PARAMETERS
 >for CHS only devices.

That comment is not accurate.  What the patch really does
is issue the IDP command for devices predating ATA-4,
regardless of whether they are CHS-only or not.

Correct behaviour, mind you.  Just the comment appeared misleading.

Oh, and what is the "major_version" variable based on?
I don't see it in 2.6.11-rc4, so it must be in the libata bk stuff.

For this usage to work, that variable has to be set from the
drive IDENTIFY data, but with a precautionary check for drives
(pre-ATA4) which may not set the version at all.  I'm guessing
this is already taken care of elsewhere in libata, right?

Cheers
-- 
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help