Thread (13 messages) 13 messages, 6 authors, 2004-08-12

Re: IDE hackery: lock fixes and hotplug controller stuff

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2004-08-12 18:10:27
Also in: lkml

On Tuesday 10 August 2004 20:23, Alan Cox wrote:
On Tue, Aug 10, 2004 at 07:16:17PM +0200, Bartlomiej Zolnierkiewicz wrote:
quoted
On Tuesday 10 August 2004 18:19, Alan Cox wrote:
quoted
-	Remove unsafe and essentially unfixable proc code for flipping
	between ide-cd and ide-scsi. Its no longer relevant with SG_IO.
Shouldn't we deprecate it first...?
It doesn't work now so it clearly isnt being used 8). We hold the lock
because its a proc function and we then replace the proc functions in the
attach method -> deadlock. It is also incredibly hard to fix without a
major rewrite.
It is a correct analysis for /proc/ide/hdx/settings:ide-scsi but not 
for /proc/ide/hdx/driver which works just fine (modulo being racy)
and your patch removes both interfaces...

Bartlomiej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help