On Fri, Jun 11 2004, Bartlomiej Zolnierkiewicz wrote:

On Friday 11 of June 2004 19:01, Jens Axboe wrote:

quoted

On Fri, Jun 11 2004, Bartlomiej Zolnierkiewicz wrote:

quoted

[PATCH] ide: kill task_[un]map_rq()

PIO handlers under CONFIG_IDE_TASKFILE_IO=n are never used for bio
based requests (rq->bio is always NULL) so we can use rq->buffer
directly instead of calling ide_[un]map_buffer().

Not so sure if it's ever used for something requiring performance, and
even if it isn't then it may still be worth it to keep the mapping and
instead fix the task setup to map in user data with blk_rq_map_user() by
fixing up ide_taskfile_ioctl().

I agree about blk_rq_map_user() (I even did it once around 2.5.60-70).
However I think that we are better off (slowly) killing old taskfile
handlers completely (this patch is for old taskfile handlers only)
and using CONFIG_IDE_TASKFILE_IO versions (which know about rq->bio).

Ah these are the old handlers. Then I fully agree, nuk the mappings.

-- 
Jens Axboe