Thread (4 messages) 4 messages, 2 authors, 2004-06-11

Re: [PATCH] IDE update for 2.6.7-rc3 [11/12]

From: Jens Axboe <hidden>
Date: 2004-06-11 17:08:37
Also in: lkml

On Fri, Jun 11 2004, Bartlomiej Zolnierkiewicz wrote:
[PATCH] ide: kill task_[un]map_rq()

PIO handlers under CONFIG_IDE_TASKFILE_IO=n are never used for bio
based requests (rq->bio is always NULL) so we can use rq->buffer
directly instead of calling ide_[un]map_buffer().
Not so sure if it's ever used for something requiring performance, and
even if it isn't then it may still be worth it to keep the mapping and
instead fix the task setup to map in user data with blk_rq_map_user() by
fixing up ide_taskfile_ioctl().

It would make HDIO_DRIVE_TASKFILE a whole lot nicer.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help