Timothy Miller wrote:

Jens Axboe wrote:

quoted

- The optimal_sectors calculation is just an average of previous maximum
  with current maximum. The scheme has a number of break down points,
  for instance writes starving reads will give you a bad read execution
  time, further limiting ->optimal_sectors[READ]

I did look through your code a bit, but one thing to be concerned with 
is that going only on max throughput might be fooled by cache hits on 
the drive.

If you are taking your samples over time, that shouldn't matter...  if 
the system workload is such that you are hitting the drive cache the 
majority of the time, you're not being "fooled" by cache hits, the patch 
would be taking those cache hits into account.

If the system isn't hitting the drive cache the majority of the time, 
statistical sampling will automatically notice that too...

	Jeff