Thread (104 messages) 104 messages, 20 authors, 2004-04-03

Re: [PATCH] speed up SATA

From: Jeff Garzik <hidden>
Date: 2004-03-28 00:00:02
Also in: lkml

Nick Piggin wrote:
Jeff Garzik wrote:
quoted
Nick Piggin wrote:
quoted
I think 32MB is too much. You incur latency and lose
scheduling grainularity. I bet returns start diminishing
pretty quickly after 1MB or so.


See my reply to Bart.

Also, it is not the driver's responsibility to do anything but export 
the hardware maximums.

It's up to the sysadmin to choose a disk scheduling policy they like, 
which implies that a _scheduler_, not each individual driver, should 
place policy limitations on max_sectors.
Yeah I suppose you're right there. In practice it doesn't
work that way though, does it?
Not my problem  <grin>

People shouldn't be tuning max_sectors at the source code level: that 
just embeds the policy decisions in the source code, and leads to 
constant fiddling with the driver to get things "just right". Over time, 
disks get faster and latency falls naturally.  Thus the definition of 
"just right" must be constantly tuned in the driver source code as time 
passes.

I also wouldn't want to lock out any users who wanted to use SATA at 
full speed ;-)

	Jeff


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help