Re: [PATCH 03/10] i2c: xiic: Fix coding style issues
From: Joe Perches <joe@perches.com>
Date: 2021-05-31 17:01:33
Also in:
linux-arm-kernel, lkml
On Mon, 2021-05-31 at 07:19 -0600, Raviteja Narayanam wrote:
From: Michal Simek <redacted> Most of these stuff are reported by checkpatch.
trivia:
quoted hunk ↗ jump to hunk
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
[]
quoted hunk ↗ jump to hunk
@@ -519,8 +522,8 @@ static irqreturn_t xiic_process(int irq, void *dev_id)/* Service requesting interrupt */ if ((pend & XIIC_INTR_ARB_LOST_MASK) || - ((pend & XIIC_INTR_TX_ERROR_MASK) && - !(pend & XIIC_INTR_RX_FULL_MASK))) { + ((pend & XIIC_INTR_TX_ERROR_MASK) && + !(pend & XIIC_INTR_RX_FULL_MASK))) {
This last line would more commonly be indented one more space to
align to the appropriate open parenthesis depth.
tab then 4 spaces for
((pend & XIIC_INTR_TX_ERROR_MASK) &&
tab then 5 spaces for
!(pend & XIIC_INTR_RX_FULL_MASK))) {