Thread (13 messages) 13 messages, 6 authors, 2016-07-28

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

From: Wolfram Sang <hidden>
Date: 2016-07-25 20:43:30
Also in: linux-input, lkml

On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote:
cros_ec_cmd_xfer returns success status if the command transport
completes successfully, but the execution result is incorrectly ignored.
In many cases, the execution result is assumed to be successful, leading
to ignored errors and operating on uninitialized data.

We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
problems. Let's use it.

Signed-off-by: Brian Norris <briannorris@chromium.org>
I agree with Dmitry about Thierry pushing the patch. So:

Acked-by: Wolfram Sang <redacted>

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help