Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
flat view
From: Javier Martinez Canillas <hidden>
Date: 2016-07-25 19:46:10
Also in:
linux-input, lkml
Hello Brian, On 07/25/2016 02:14 PM, Brian Norris wrote:
cros_ec_cmd_xfer returns success status if the command transport completes successfully, but the execution result is incorrectly ignored. In many cases, the execution result is assumed to be successful, leading to ignored errors and operating on uninitialized data. We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these problems. Let's use it. Signed-off-by: Brian Norris <briannorris@chromium.org> ---
Patch looks good to me. Reviewed-by: Javier Martinez Canillas <redacted> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America