Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

From
Wolfram Sang <hidden>
Date
2014-02-28 21:21:42
Also in
lkml
Reply to
David Howells, 2014-02-27
quoted
Also, the I2C tracing has first 'f' then 'a', that should be consistent,
too.
Flags first or address first?  Do you have a preference (for both)?
I'd say address first, yet no strong preference.
quoted
Can we have something like this for 'flags'?
There's a __print_flags() which should work.  One thing I'm concerned about
there is how do we handle more flags being added - does that count as an ABI
break if the printed format changes?
Not sure, I mean, this is debug output, no?
SMBus flags are basically the same as I2C flags, right?
Basically, yes.

Thanks,

   Wolfram

Attachments

Thread (14 messages) 14 messages, 2 authors, last reply 2014-03-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help