Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-03-10 09:28:48
Also in:
kvmarm, linux-acpi, linux-arch, linux-arm-kernel, linux-devicetree, linux-pci, lkml
On Fri, Mar 07, 2025 at 02:02:59PM -0800, Roman Kisel wrote:
To boot on ARM64, VMBus requires configuring interrupts. Missing DMA coherence property is sub-optimal as the VMBus transations are cache-coherent. Add interrupts to be able to boot on ARM64. Add DMA coherence to avoid doing extra work on maintaining caches on ARM64.
How do you add it?
quoted hunk ↗ jump to hunk
Signed-off-by: Roman Kisel <redacted> --- .../devicetree/bindings/bus/microsoft,vmbus.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml b/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml index a8d40c766dcd..3ab7d0116626 100644 --- a/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml +++ b/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml@@ -28,13 +28,16 @@ properties: required: - compatible - ranges + - interrupts - '#address-cells' - '#size-cells' -additionalProperties: false +additionalProperties: true
This is neither explained in commit msg nor correct. Drop the change. You cannot have device bindings ending with 'true' here - see talks, example-bindings, writing-schema and whatever resource is there. Best regards, Krzysztof