RE: [PATCH] function mana_hwc_create_wq leaks memory
From: Dexuan Cui <decui@microsoft.com>
Date: 2021-06-10 17:18:20
Also in:
lkml, netdev
quoted hunk ↗ jump to hunk
From: Dhiraj Shah <redacted> Sent: Thursday, June 10, 2021 8:29 AM ... memory space allocated for the queue in function mana_gd_create_hwc_queue is not freed during error condition. Signed-off-by: Dhiraj Shah <redacted> --- drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.cb/drivers/net/ethernet/microsoft/mana/hw_channel.c index 1a923fd99990..4aa4bda518fb 100644--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c@@ -501,8 +501,10 @@ static int mana_hwc_create_wq(structhw_channel_context *hwc, *hwc_wq_ptr = hwc_wq; return 0; out: - if (err) + if (err) {
Here the 'err' must be non-zero. Can you please remove this 'if'?
+ kfree(queue); mana_hwc_destroy_wq(hwc, hwc_wq); + } return err; }
Reviewed-by: Dexuan Cui <decui@microsoft.com>