[PATCH] function mana_hwc_create_wq leaks memory
From: Dhiraj Shah <hidden>
Date: 2021-06-10 15:30:45
Also in:
lkml, netdev
Subsystem:
hyper-v/azure core and drivers, networking drivers, the rest · Maintainers:
"K. Y. Srinivasan", Haiyang Zhang, Wei Liu, Dexuan Cui, Long Li, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
memory space allocated for the queue in function
mana_gd_create_hwc_queue is not freed during error condition.
Signed-off-by: Dhiraj Shah <redacted>
---
drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index 1a923fd99990..4aa4bda518fb 100644
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -501,8 +501,10 @@ static int mana_hwc_create_wq(struct hw_channel_context *hwc,
*hwc_wq_ptr = hwc_wq;
return 0;
out:
- if (err)
+ if (err) {
+ kfree(queue);
mana_hwc_destroy_wq(hwc, hwc_wq);
+ }
return err;
}
--
2.30.1 (Apple Git-130)