On Wed, Apr 7, 2021 at 5:30 PM Luis Chamberlain [off-list ref] wrote:

On Wed, Apr 07, 2021 at 10:33:44AM +0300, Andy Shevchenko wrote:

quoted

On Wed, Apr 7, 2021 at 10:25 AM Luis Chamberlain [off-list ref] wrote:

quoted

On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:

...

quoted

quoted

Why is it worth it to add another file just for this?

The main point is to break tons of loops that prevent having clean
headers anymore.

In this case, see bug.h, which is very important in this sense.

OK based on the commit log this was not clear, it seemed more of moving
panic stuff to its own file, so just cleanup.

Sorry for that. it should have mentioned the kernel folder instead of
lib. But I think it won't clarify the above.

In any case there are several purposes in this case
 - dropping dependency in bug.h
 - dropping a loop by moving out panic_notifier.h
 - unload kernel.h from something which has its own domain

I think that you are referring to the commit message describing 3rd
one, but not 1st and 2nd.

I will amend this for the future splits, thanks!

quoted

quoted

 Seems like a very
small file.

If it is an argument, it's kinda strange. We have much smaller headers.

The motivation for such separate file was just not clear on the commit
log.

-- 
With Best Regards,
Andy Shevchenko