Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

From
Andy Shevchenko <hidden>
Date
2021-04-07 07:34:16
Also in
kexec, linux-arch, linux-fsdevel, linux-remoteproc, linuxppc-dev, lkml, rcu
Reply to
Luis Chamberlain, 2021-04-06
On Wed, Apr 7, 2021 at 10:25 AM Luis Chamberlain [off-list ref] wrote:
On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
quoted
diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h
new file mode 100644
index 000000000000..41e32483d7a7
--- /dev/null
+++ b/include/linux/panic_notifier.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LINUX_PANIC_NOTIFIERS_H
+#define _LINUX_PANIC_NOTIFIERS_H
+
+#include <linux/notifier.h>
+#include <linux/types.h>
+
+extern struct atomic_notifier_head panic_notifier_list;
+
+extern bool crash_kexec_post_notifiers;
+
+#endif       /* _LINUX_PANIC_NOTIFIERS_H */
Why is it worth it to add another file just for this?
The main point is to break tons of loops that prevent having clean
headers anymore.

In this case, see bug.h, which is very important in this sense.
 Seems like a very
small file.
If it is an argument, it's kinda strange. We have much smaller headers.

-- 
With Best Regards,
Andy Shevchenko
Thread (18 messages) 18 messages, 12 authors, last reply 2021-04-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help