Re: [patch V2 15/46] x86/irq: Consolidate DMAR irq allocation

On Wed, Aug 26 2020 at 09:50, Megha Dey wrote:

quoted

@@ -329,15 +329,15 @@ static struct irq_chip dmar_msi_controll
  static irq_hw_number_t dmar_msi_get_hwirq(struct msi_domain_info *info,
  					  msi_alloc_info_t *arg)
  {
-	return arg->dmar_id;
+	return arg->hwirq;

Shouldn't this return the arg->devid which gets set in dmar_alloc_hwirq?

Indeed.