[patch V2 01/46] iommu/amd: Prevent NULL pointer dereference
flat view
STALE1360d
From: Thomas Gleixner <hidden>
Date: 2020-08-26 12:02:08
Also in:
linux-iommu, linux-pci, lkml, xen-devel
From: Thomas Gleixner <redacted> Dereferencing irq_data before checking it for NULL is suboptimal. Signed-off-by: Thomas Gleixner <redacted> --- drivers/iommu/amd/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c@@ -3717,8 +3717,8 @@ static int irq_remapping_alloc(struct ir for (i = 0; i < nr_irqs; i++) { irq_data = irq_domain_get_irq_data(domain, virq + i); - cfg = irqd_cfg(irq_data); - if (!irq_data || !cfg) { + cfg = irq_data ? irqd_cfg(irq_data) : NULL; + if (!cfg) { ret = -EINVAL; goto out_free_data; }