Thread (32 messages) 32 messages, 2 authors, 2021-12-02

Re: [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-12-02 10:59:07
Also in: linux-kselftest, lkml

On Wed, Dec 01, 2021 at 02:11:28PM +0100, Bartosz Golaszewski wrote:
On Tue, Nov 30, 2021 at 10:04 PM Bartosz Golaszewski [off-list ref] wrote:
...
Let me maybe rephrase the problem: currently, for GPIO devices
instantiating multiple banks created outside of the OF or ACPI
frameworks (e.g. instantiated manually and configured using a
hierarchy of software nodes with a single parent swnode and a number
of child swnodes representing the children), it is impossible to
assign firmware nodes other than the one representing the top GPIO
device to the gpiochip child devices.

In fact if we want to drop the OF APIs entirely from gpiolib - this
would be the right first step as for gpio-sim it actually replaces the
gc->of_node = some_of_node; assignment that OF-based drivers do for
sub-nodes defining banks and it does work with device-tree (I verified
that too) thanks to the fwnode abstraction layer.
In exchange of acknowledgements I confirm that I understood the issue
you are describing. What I still don't like is this band-aid:ish approach.
What we really need is to replace of_node by fwnode in GPIO library once
for all. But it can be done later after your simulation series (or before,
i.o.w. independently), hence I propose to update TODO and do it separately.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help