Thread (14 messages) 14 messages, 3 authors, 2022-01-13

Re: [PATCH v2 1/3] pinctrl: cherryview: Don't use pin/offset 0 to mark an interrupt line as unused

From: Hans de Goede <hidden>
Date: 2021-11-27 21:50:53
Also in: linux-acpi

Hi,

On 11/26/21 18:43, Andy Shevchenko wrote:
On Thu, Nov 18, 2021 at 01:26:28PM +0200, Andy Shevchenko wrote:
quoted
On Thu, Nov 18, 2021 at 11:56:48AM +0100, Hans de Goede wrote:
quoted
Offset/pin 0 is a perfectly valid offset, so stop using it to have
the special meaning of interrupt line not used in the intr_lines.

Instead introduce a new special INTR_LINE_UNUSED value which is never
a valid offset and use that to indicate unused interrupt lines.
...
quoted
+#define INTR_LINE_UNUSED		U32_MAX
Funny, I have had something similar in my local branch for a few years ;-)

+#define CHV_INVALID_HWIRQ      ((unsigned int)INVALID_HWIRQ)
I will rename this when applying. I assume there is no objection on doing it.
Yes that is fine.

Regards,

Hans

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help