Re: [PATCH v5 2/8] configfs: use BIT() for internal flags

[PATCH v5 0/8] gpio: implement the configfs testing module · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 1/8] configfs: increase the item name length · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 2/8] configfs: use BIT() for internal flags · Bartosz Golaszewski <hidden> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Christoph Hellwig <hch@lst.de> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Bartosz Golaszewski <hidden> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Christoph Hellwig <hch@lst.de> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Geert Uytterhoeven <geert@linux-m68k.org> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Christoph Hellwig <hch@lst.de> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Bartosz Golaszewski <hidden> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Geert Uytterhoeven <geert@linux-m68k.org> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Bartosz Golaszewski <hidden> · 2021-09-20
Re: [PATCH v5 2/8] configfs: use BIT() for internal flags · Matthew Wilcox <willy@infradead.org> · 2021-09-20
[PATCH v5 3/8] configfs: implement committable items · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 4/8] samples: configfs: add a committable group · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 6/8] selftests: gpio: provide a helper for reading chip info · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 5/8] gpio: sim: new testing module · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 7/8] selftests: gpio: add a helper for reading GPIO line names · Bartosz Golaszewski <hidden> · 2021-09-20
[PATCH v5 8/8] selftests: gpio: add test cases for gpio-sim · Bartosz Golaszewski <hidden> · 2021-09-20

From: Christoph Hellwig <hch@lst.de>
Date: 2021-09-20 14:30:59
Also in: linux-doc, lkml

On Mon, Sep 20, 2021 at 04:29:30PM +0200, Geert Uytterhoeven wrote:

Hi Christoph,

On Mon, Sep 20, 2021 at 4:09 PM Christoph Hellwig [off-list ref] wrote:

quoted

On Mon, Sep 20, 2021 at 04:05:03PM +0200, Bartosz Golaszewski wrote:

quoted

For better readability and maintenance: use the BIT() macro for flag
definitions.

NAK.  BIT() is the stupidest macro in the kernel and shall not be used
ever.  And I'm pretty sure we had this discussion a few times.

Care to explain why it is a stupid macro?

Please look at the previous thread.  I'm tired of this discussion.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help