Re: [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property
From: Serge Semin <hidden>
Date: 2021-08-11 12:48:00
Also in:
lkml
From: Serge Semin <hidden>
Date: 2021-08-11 12:48:00
Also in:
lkml
Hello Linus On Wed, Aug 11, 2021 at 02:40:49PM +0200, Linus Walleij wrote:
On Wed, Aug 4, 2021 at 4:44 PM Andy Shevchenko [off-list ref] wrote:quoted
On Wed, Aug 04, 2021 at 03:44:33PM +0300, Serge Semin wrote:quoted
Thus, yes, I think we need to make sure here that the property is only used in framework of the kernel and isn't passed via inappropriate paths like DT/ACPI fw so not to get into the maintainability troubles in future.Got it. I'll add the additional check in next version.
This seems reasonable for me, if you can get this done with some kind of elegance.
There is v2 of this series has already been posted: https://lore.kernel.org/linux-gpio/20210804160019.77105-1-andriy.shevchenko@linux.intel.com/ (local) with the denoted concern taken into account. -Sergey
Maybe use the "linux,gpio-base" property as mentioned so it is clear that this is a Linux-internal thing only. Yours, Linus Walleij