On Mon, Aug 2, 2021 at 5:23 PM Serge Semin [off-list ref] wrote:

On Mon, Jul 26, 2021 at 03:54:36PM +0300, Andy Shevchenko wrote:

quoted

Platform data is a legacy interface to supply device properties
to the driver. In this case we don't have anymore in-kernel users
for it. Just remove it for good.

quoted

+struct dwapb_port_property {
+     struct fwnode_handle *fwnode;
+     unsigned int idx;
+     unsigned int ngpio;
+     unsigned int gpio_base;
+     int irq[DWAPB_MAX_GPIOS];
+};
+
+struct dwapb_platform_data {
+     struct dwapb_port_property *properties;
+     unsigned int nports;
+};
+
 struct dwapb_gpio;

If you need to resend the series anyway could you please move the
structures declarations to being below the forward declaration of the
dwapb_gpio structure? Of course it's not that critical, but for the
sake of just not to have the later one left somewhere in the middle of
the unrelated structures and for at least to keep some order in the
declarations.

Fine with me, I'll modify accordingly in the next version, thanks for
the review!

Then feel free to add:
Acked-by: Serge Semin <redacted>

The whole series has been tested on Baikal-T1 SoC:
Tested-by: Serge Semin <redacted>

-- 
With Best Regards,
Andy Shevchenko