Re: [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: Add base dts file
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-06-07 15:22:41
Also in:
linux-arm-msm, linux-devicetree, lkml
On 07-06-21, 17:08, Bhupesh Sharma wrote:
Add base DTS file for sa8155p-adp and enable boot to console, tlmm reserved range and also include pmic file(s).
I see ufs added too, pls mention that as well --- a/arch/arm64/boot/dts/qcom/Makefile
quoted hunk ↗ jump to hunk
+++ b/arch/arm64/boot/dts/qcom/Makefile@@ -71,6 +71,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb +dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb
I think this should go before sdm..
+ vdd_usb_hs_core: + vdda_pll_hv_cc_ebi01: + vdda_pll_hv_cc_ebi23: + vdda_ufs_2ln_core: + vdda_ufs_2ln_core: + vdda_usb_ss_core: + vdda_usb_ss_dp_core_1: + vdda_usb_ss_dp_core_2: + vdda_sp_sensor: + vdda_qlink_lv: + vdda_qlink_lv_ck: + vdda_qrefs_0p875_5:
I didnt find these labels very useful, so maybe remove? It helped me to understand that a regulator is vreg_l5a_0p88 as it implies I am using l5a with 0p88V :)
+ vreg_l5a_0p88: ldo5 {
+ regulator-min-microvolt = <880000>;
+ regulator-max-microvolt = <880000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;Pls do add regulator-name property, it helps in understanding which ldo in logs/debugfs, otherwise ldo5 will comes for both pmics -- ~Vinod