Morning folks!

On Fri, 2021-05-21 at 18:35 +0200, Bartosz Golaszewski wrote:

On Fri, May 21, 2021 at 12:31 PM Vaittinen, Matti
[off-list ref] wrote:

quoted

On Fri, 2021-05-21 at 10:38 +0200, Bjørn Mork wrote:

quoted

Michael Walle [off-list ref] writes:

quoted

Am 2021-05-21 08:28, schrieb Matti Vaittinen:

quoted

Slightly simplify the devm_gpio_regmap_register() by using
the
devm_add_action().

You should probably use the devm_add_action_or_reset() wrapper
here
too,
catching the unlikely devm_add_action() alloc failure.

I was thinking of it but as the gpio registration succeeded I was
thinking that we could go on with it - (which means we can proceed
but
the gpio is never released.)

I am not sure how much difference it makes in the case of small
alloc
failure ;)

But as it seems I am in any case re-spinning this I can change this
to
the devm_add_action_or_reset() and fail the gpio_regmap
registration if
alloc fails.

Best Regards
        Matti Vaittinen

Hi Matti,

Please use the reset variant. We always want to roll-back the changes
done in a function before the failure and propagate the error code.

Right. I'll do that. I hope to be able to re-spin this today.

Best Regards
	-- Matti