On Tue, Feb 9, 2021 at 2:54 PM Nikita Shubin [off-list ref] wrote:

On Tuesday, 9 February 2021 15:46:19 MSK Andy Shevchenko wrote:

quoted

On Tue, Feb 9, 2021 at 2:35 PM Nikita Shubin

[off-list ref] wrote:

quoted

quoted

On Monday, 8 February 2021 16:20:17 MSK Andy Shevchenko wrote:

quoted

On Mon, Feb 8, 2021 at 11:00 AM Nikita Shubin

[off-list ref] wrote:

...

quoted

quoted

quoted

quoted

+       ic->name = devm_kasprintf(dev, GFP_KERNEL, "gpio-irq-%s",
label);

Is the label being NULL okay?

You mean ENOMEM should be honored ? I think you are right about it.

Depending on what is the answer to the question below. If NULL label
is okay (and here is just optional) then simply comment it in the
code, otherwise check is missed.

quoted

quoted

The label is taken from ep93xx_gpio_banks[], so unless we explicitly
pass zero to ep93xx_init_irq_chip(), we are ok.

Maybe I was unclear, let me rephrase: Is the *resulting* label being
NULL okay?

-- 
With Best Regards,
Andy Shevchenko