Thread (11 messages) 11 messages, 5 authors, 2021-01-27
STALE1956d

[PATCH 4/6] irqchip/ixp4xx: Fix return check of __irq_domain_alloc_irqs

From: Adam Lackorzynski <hidden>
Date: 2021-01-02 18:22:10
Also in: linux-arm-kernel
Subsystem: arm/intel ixp4xx arm architecture, irqchip drivers, the rest · Maintainers: Linus Walleij, Imre Kaloz, Thomas Gleixner, Linus Torvalds

0 is not a proper IRQ number and also indicates failure.

Signed-off-by: Adam Lackorzynski <redacted>
---
 drivers/irqchip/irq-ixp4xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c
index 37e0749215c7..54dcffe2309f 100644
--- a/drivers/irqchip/irq-ixp4xx.c
+++ b/drivers/irqchip/irq-ixp4xx.c
@@ -355,7 +355,7 @@ void __init ixp4xx_irq_init(resource_size_t irqbase,
 					      &fwspec,
 					      false,
 					      NULL);
-		if (ret < 0) {
+		if (ret <= 0) {
 			pr_crit("IXP4XX: can not allocate irqs in hierarchy %d\n",
 				ret);
 			return;
-- 
2.30.0.rc2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help