[PATCH 2/6] irqchip/armada-370-xp: Fix return check in IPI alloc
From: Adam Lackorzynski <hidden>
Date: 2021-01-02 18:19:32
Also in:
linux-arm-kernel
Subsystem:
arm/marvell kirkwood and armada 370, 375, 38x, 39x, xp, 3700, 7k/8k, cn9130 soc support, irqchip drivers, the rest · Maintainers:
Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Thomas Gleixner, Linus Torvalds
__irq_domain_alloc_irqs returns a negative error code upon failure, not only 0. Also use irq_domain_alloc_irqs to require less default arguments. Signed-off-by: Adam Lackorzynski <redacted> --- drivers/irqchip/irq-armada-370-xp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 32938dfc0e46..b5e3aacdc2d1 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c@@ -430,9 +430,9 @@ static __init void armada_xp_ipi_init(struct device_node *node) return; irq_domain_update_bus_token(ipi_domain, DOMAIN_BUS_IPI); - base_ipi = __irq_domain_alloc_irqs(ipi_domain, -1, IPI_DOORBELL_END, - NUMA_NO_NODE, NULL, false, NULL); - if (WARN_ON(!base_ipi)) + base_ipi = irq_domain_alloc_irqs(ipi_domain, IPI_DOORBELL_END, + NUMA_NO_NODE, NULL); + if (WARN_ON(base_ipi <= 0)) return; set_smp_ipi_range(base_ipi, IPI_DOORBELL_END);
--
2.30.0.rc2