Thread (28 messages) 28 messages, 8 authors, 2019-09-18

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

From: Atish Patra <hidden>
Date: 2018-10-15 22:45:49
Also in: linux-devicetree, linux-pwm, linux-riscv, lkml

On 10/10/18 6:51 AM, Thierry Reding wrote:
On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote:
[...]
quoted
+- interrupts: one interrupt per PWM channel (currently unused in the driver)
This should probably say what the interrupt is used for. And once you
have that, remove the comment about it being unused in the driver. DT
is OS agnostic, so "driver" is very unspecific and your claim may
actually be false.

Thierry
As per my understanding, they are generated by hardware but no usage of 
pwm interrupts as of now.

I am not sure if removing the entire entry is a good idea.
What would be the best way to represent that information ?

May be this ?

+-interrupts: one interrupt per PWM channel. No usage in HiFive 
Unleashed SoC.

Regards,
Atish
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help