Thread (2 messages) 2 messages, 2 authors, 2017-01-27

Re: [PATCH v2 6/9] arm64: dts: allwinner: add Allwinner H5 .dtsi

From: Maxime Ripard <hidden>
Date: 2017-01-27 16:08:36
Also in: alsa-devel, linux-arm-kernel, linux-clk, linux-devicetree, lkml

Possibly related (same subject, not in this thread)

On Thu, Jan 26, 2017 at 11:48:56PM +0800, Icenowy Zheng wrote:
+		mmc@01c0f000 {
Please use a label based syntax here too.
+			compatible = "allwinner,sun50i-a64-mmc",
+				     "allwinner,sun5i-a13-mmc";
The compatibility with the A13 has never been true, and the compatible
should be "allwinner,sun50i-h5-mmc", "allwinner,sun50i-a64-mmc".
+			clocks = <&ccu CLK_BUS_MMC0>, <&ccu CLK_MMC0>;
+			clock-names = "ahb", "mmc";
+		};
+
+		mmc@01c10000 {
+			compatible = "allwinner,sun50i-a64-mmc",
+				     "allwinner,sun5i-a13-mmc";
+			clocks = <&ccu CLK_BUS_MMC1>, <&ccu CLK_MMC1>;
+			clock-names = "ahb", "mmc";
+		};
+
+		mmc@01c11000 {
+			compatible = "allwinner,sun50i-a64-mmc",
And this is very likely to use the emmc compatible.
+				     "allwinner,sun5i-a13-mmc";
+			clocks = <&ccu CLK_BUS_MMC2>, <&ccu CLK_MMC2>;
+			clock-names = "ahb", "mmc";
+		};
+
+		clock@01c20000 {
+			compatible = "allwinner,sun50i-h5-ccu",
+				     "allwinner,sun8i-h3-ccu";
+		};
If it doesn't have the same clocks, it's not compatible with the H3.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help