RE: [PATCH 3/3 v2] GPIO: gpio-dwapb: Suspend & Resume PM enabling
From: Chen, Alvin <hidden>
Date: 2014-09-22 01:37:18
Also in:
linux-devicetree, lkml
From: Chen, Alvin <hidden>
Date: 2014-09-22 01:37:18
Also in:
linux-devicetree, lkml
quoted
+/* Store GPIO context across system-wide suspend/resume transitions +*/ static struct dwapb_context { + u32 data[DWAPB_MAX_PORTS]; + u32 dir[DWAPB_MAX_PORTS]; + u32 ext[DWAPB_MAX_PORTS]; + u32 int_en; + u32 int_mask; + u32 int_type; + u32 int_pol; + u32 int_deb; +} dwapb_context;NAK, this should STILL be part of the device state container. Not a local variable. I've said this before. Please fix this, thanks.
Linus, please review Version 5 that I sent on Sep.17th. I have fixed it in the v5.