On Fri, Sep 5, 2014 at 7:53 AM, Weike Chen [off-list ref] wrote:

This patch enables suspend and resume mode for the power management, and
it is based on Josef Ahmad's previous work.

Reviewed-by: Hock Leong Kweh <redacted>
Reviewed-by: Shevchenko, Andriy <redacted>
Signed-off-by: Weike Chen <redacted>

(...)

+/* Store GPIO context across system-wide suspend/resume transitions */
+static struct dwapb_context {
+       u32 data[DWAPB_MAX_PORTS];
+       u32 dir[DWAPB_MAX_PORTS];
+       u32 ext[DWAPB_MAX_PORTS];
+       u32 int_en;
+       u32 int_mask;
+       u32 int_type;
+       u32 int_pol;
+       u32 int_deb;
+} dwapb_context;

NAK, this should STILL be part of the device state container. Not
a local variable.

I've said this before. Please fix this, thanks.

Yours,
Linus Walleij