Thread (26 messages) 26 messages, 4 authors, 2021-12-30

Re: [PATCH v10 1/5] fs: split off do_user_path_at_empty from user_path_at_empty()

From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2021-12-30 01:10:10
Also in: io-uring

On Wed, Dec 29, 2021 at 12:29:58PM -0800, Stefan Roesch wrote:
This splits off a do_user_path_at_empty function from the
user_path_at_empty_function. This is required so it can be
called from io_uring.
Umm...  Why do you bother with that wrapper?  filename_lookup() is already
there and already non-static.  Granted, its user outside of fs/namei.c
is ugly as hell, but looking at this series, I'd rather have the damn
thing call filename_lookup() directly.  _Or_, if you really feel like
doing that wrapper, make it inline in internal.h and have fs_parser.c
use call the same thing - it also passes NULL as the last argument.

Said that, I really don't see the point of having that wrapper in the
first place.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help