Thread (10 messages) 10 messages, 4 authors, 2021-06-17

Re: [PATCH] afs: fix tracepoint string placement with built-in AFS

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-06-17 13:37:24
Also in: lkml

On Thu, 17 Jun 2021 13:04:49 +0100
David Howells [off-list ref] wrote:
Steven Rostedt [off-list ref] wrote:
quoted
Looks fine to me, and even saves 4 bytes on 64 bit machines (events are
rounded up to 4 byte increments, so the u16 is no different than a u32
here).  
Can I put that down as a Reviewed-by?
Sure. I was going to recommend consolidating the mappings a bit more to
have the enums and numbers defined in a single macro, but then I saw that
it matches the rest of the header file, and to do the consolidation would
require modifying the existing code, which I thought wasn't worth the
effort.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help